Moving books between the To Read/Reading/Read shelves does not do anything

[SaturnsGlaive]

Describe the bug When a user moves a book between the To Read/Reading/Read shelves, nothing happens. Clicking the "move" button again will show a pop up, if applicable.

The following gif shows it from the book shleves page but this is also seen on the singular book page as well.

To Reproduce Steps to reproduce the behavior:

1. Go to the page of a book that has already been shelved in "To Read"
2. Click on "Move Book" under the "To Read" shelf
3. Select "Read"
4. Note nothing happens
5. Refresh page
6. Note book is still in "To Read"

Expected behavior The book should be moved to the new shelf and upon page refresh, the new shelf should be shown instead of the old shelf.

Instance https://bookrastinating.com

Desktop (please complete the following information):

• Manjaro
• Firefox 106.0.4

[cincodenada]

Okay, yeah I'm seeing this too - is it only broken on the shelf views for you as well? For me, the other shelf-switchers (e.g. on the book page) still work as expected.

[SaturnsGlaive]

Okay, yeah I'm seeing this too - is it only broken on the shelf views for you as well? For me, the other shelf-switchers (e.g. on the book page) still work as expected.

The shelf switchers on the left hand side of the book page works as expected.

But the individual shelf switchers on the book page do not work.

[mouse-reeve]

oooh thank you for the video! there's probably an issue with the html attribute IDs

[placoderm]

I'm seeing the same behaviour. I'm using FireFox 107 on Windows.

[marcusyoung]

I have the same issue using a chrome-based browser. Additional information to note:

• when an option is clicked the scroll bar for the page disappears
• only seems to occur for built-in shelves when a modal needs to be shown. When books are moved to custom shelves the move functions correctly.
• changing status in Lists and using the drop down underneath the book cover (as noted above) works correctly

[asmaloney]

I also experienced this. Firefox 108.1 and Brave 1.46.144 on macOS. No errors in the console on either.

When I select "Stopped Reading" from the dropdown, the menu disappears and nothing happens.

If I then click "Move book" like a button instead of using the dropdown it gives me the dialog for "Stopped Reading" to change the dates and so on - and then it applies it.

So there's some strange "select the item, but don't execute" state going on with the dropdown menu items.

[DougNix]

I see these same issues. I can't get the "Move to shelf" action to work consistently. If the move works, which it has occasionally, attempting another move will fail consistently.

[asmaloney]

I have tracked down the problem to the complicated dropdown menu structure (ul/li/details/summary/form/button). It's using details and summary elements in a strange way that is somehow interfering with things. If I take a menu item outside of the dropdown it works as expected.

I've started to convert dropdowns to straight divs & links (like the bulma examples) instead of the ul/li/details/summary/form/button structure. It works and the code is easier to read & understand, but I'm sure I'm missing some edge cases. Once I get it cleaned up I will submit a WIP PR to get feedback.

[cincodenada]

Hello @asmaloney , thank you for looking into this! I don't want to make things too complicated, but I do have a concern about just removing the details/summary.

One of the goals of this project (that Bulma doesn't share) is to work without Javascript enabled, and I believe that is the purpose of the details/summary structure. Do your changes preserve that functionality? Have you determined what about the details/summary is causing problems? We use that structure in many dropdowns across the project, and generally it works as expected.

[asmaloney]

...without Javascript enabled... Do your changes preserve that functionality?

Ah, nope. I've used bulma on other projects, but never without JS.

The README says that the frontend uses "Vanilla JavaScript, in moderation". No mention of working without JS (either there or in the contributing docs). If that's a goal/requirement, then this should be updated!

Have you determined what about the details/summary is causing problems?

I have not. It's just way too convoluted/complex for me to pick apart. That's why I was simplifying it.

[cincodenada]

The README says that the frontend uses "Vanilla JavaScript, in moderation". No mention of working without JS (either there or in the contributing docs). If that's a goal/requirement, then this should be updated!

I think we just have different opinions on what "in moderation" means, which is understandable - and I agree, if we want to preserve functionality like this, we should be clearer about it in the docs! So that's on us.

I don't know if the project has a stance on what exactly that means - personally, I would like to see, as much as possible, Javascript for progressive enhancement only - that is, it might make a feature better or more interactive, but a feature shouldn't be totally broken by disabling Javascript. I also am not sure how much we accomplish this as a whole - I know we've gone much further in our efforts to do so historically than usual - note that the entire sidebar on the homepage works (albeit slower, with more page reloads) without Javascript enabled.

My goal here is also to explain that the complexity had a purpose: it's not convoluted because someone didn't know what they were doing - it's intentionally a tradeoff of more complexity in the HTML, in order to reduce dependence on Javascript, and simplifying it is also giving up that functionality.