bookwyrm-social / bookwyrm

Social reading and reviewing, decentralized with ActivityPub
http://joinbookwyrm.com/
Other
2.17k stars 255 forks source link

Czech special characters #2769

Open Blechpirat opened 1 year ago

Blechpirat commented 1 year ago

Describe the bug I added a book by Eduard Petiška. The first time the system created an author named Eduard Petiska (replacing š with s), when I tried to correct that, the book was saved without an author.

To Reproduce Steps to reproduce the behavior:

  1. Go to add book
  2. Add Eduard Petiška as (sole) author
  3. Save
  4. Eduard Petiska is suggested. I selected him
  5. Saved again
  6. Open the book again.
  7. delete Eduard Petiska, add Eduard Petiška
  8. save, choose new author
  9. author field is empty

Expected behavior I expected UTF-8, since other special characters (like german umlauts) worked well.

Instance books.karsten-voigt.de


Desktop (please complete the following information):

I recently updated my bookwyrm to 0.6.

Blechpirat commented 1 year ago

Someone replicated the error on buecher.pnpde.social

WesleyAC commented 1 year ago

Tried this on my dev setup, and was able to import the book successfully:

and add a second author with the same name in the edit screen:

And bookwyrm.social appears to have the correct accent.

I'm curious if books.karsten-voigt.de or buecher.pnpde.social have a weird locale, if you are the admin of one of these, could you run bw-dev dbshell, then run SHOW LC_CTYPE; in that shell and report the output?

WesleyAC commented 1 year ago

Oh, hmm, reading the report more thoroughly, it seems like the problem is that "Eduard Petiska" is in the system, making it hard/impossible to add the correct name? I still can't reproduce this, though, when I try to edit the name I get a screen like this:

Do you not see that?

Blechpirat commented 1 year ago

I did only see the Author without the special character s - I could either choose him (which world work) or select "This is a new author" which would leave the author file empty.

I'm running books.karsten-voigt.de. Bookwyrm is inside a docker.

bookwyrm=# SHOW LC_CTYPE;
  lc_ctype  
------------
 en_US.utf8
(1 row)

bookwyrm=# 

I tried to change the book once more. It looks like this to me: Bildschirmfoto vom 2023-04-04 08-18-18

But this time, saving the author worked as expected. Is this a change between 0.6 and the previous version? Because buecher.pnpde.social reported the same problem...