bookwyrm-social / bookwyrm

Social reading and reviewing, decentralized with ActivityPub
http://joinbookwyrm.com/
Other
2.26k stars 265 forks source link

Move series membership from Edition to Work #3306

Open Minnozz opened 8 months ago

Minnozz commented 8 months ago

The Wikidata property part of the series (P179) links a work (Q386724) to a series of creative works (Q7725310).

work is equivalent to our Work model. We currently store series information in the Book model, which is the parent class of both Work and Edition, but we don't expose Work to the end user: editing a "book" always edits an Edition.

I propose moving series membership from Book to Work, and making Work editable by the end user.

This would be a good time to introduce a Series model so the series of creative works Wikidata key can also be stored.

hughrun commented 7 months ago

I agree we need a Series model and that it should not link to Book.

Whether it should be linked to a Work or an Edition however depends on what we mean by "series", and this needs to be made very clear in all documentation and user interfaces to avoid confusion. A couple of examples to illustrate what I mean:

Emma / Jane Austen

The Light Fantastic / Terry Pratchett

Personally I would argue that in all the cases for Emma these are imprints rather than a "series", and therefore in our small example above only Discworld is a true series. But this is not necessarily obvious nor a universally held view (especially given that one of the imprints refers to itself as a "series"). The reason this matters is because imprints like "Penguin Classics" are only valid at an Edition level - the Everyman's Library edition is not part of the Penguin Classic "series". So how we define a series determines whether it links to Edition or Work, and vice-versa.