bookwyrm-social / bookwyrm

Social reading and reviewing, decentralized with ActivityPub
http://joinbookwyrm.com/
Other
2.24k stars 264 forks source link

Entering a quote with only a "On page" page number fails without an error #3364

Open linkclau opened 5 months ago

linkclau commented 5 months ago

Describe the bug Entering a quote with only a "ON page" page number fails without an error (e.g. https://bookwyrm.social/book/1619541)

To Reproduce Steps to reproduce the behavior:

  1. Go to https://bookwyrm.social/book/1619541
  2. Select the "Quote" tab
  3. Enter a quote, a single "On page" page number and a comment (this is my mistake, if I enter the same number in "on page" and "o" it works)
  4. Click "Post" (I left the setting on public)
  5. No error is shown, I get back on the empty quote form

Expected behavior I expect to get an error when posting without required data (and smart defaults, e.g. single page quote if only one page number is entered)

Screenshots Filled out quote form Screenshot from 2024-04-28 21-27-11 after clicking post I get here Screenshot from 2024-04-28 21-36-45

Instance On https://bookwyrm.social/user/realn2s

Additional context Found the workaround to enter the same page in "On page" and "to". So it's just confusing but basically works The error handling should be improved that I get a error message (and ideally the system also works if only one page number is entered).


Desktop (please complete the following information):

Smartphone (please complete the following information):

prolibre commented 5 months ago

Duplicate :-)

https://github.com/bookwyrm-social/bookwyrm/issues/3352

Normally this has been fixed and will be included in the next update.

gedankenstuecke commented 5 months ago

I just wanted to say thanks for folks fixing (and reporting) this, I ran into the problem as well yesterday on https://bookwyrm.social and was glad to see that you're already ahead of it! ❤️

dato commented 4 months ago

As a workaround until the next release, you can use a full range for the page (e.g., “7-7” or “7-8”).

gedankenstuecke commented 4 months ago

Thanks, that's good to know! ❤️