search

boolder-org / boolder-android

Boolder Android app https://www.boolder.com/en/app
MIT License
28 stars 12 forks source link

Implement the area detector #36

Closed wang-li closed 1 year ago

wang-li commented 1 year ago

In order to provide information to the user about the displayed area on the map, an area detector needs to be implemented first.

https://github.com/boolder-org/boolder-android/assets/8343416/471c9329-80a0-4f3f-a8cc-2f51d37898d8

This commit also updates the libs that are used in the project.

Resolves #25

nmondollot commented 1 year ago

Awesome!

It's a great milestone towards https://github.com/boolder-org/boolder-android/issues/27 :)

Small question: are performances ok even on slower devices?

wang-li commented 1 year ago

Small question: are performances ok even on slower devices?

The oldest device that I have is a OnePlus One, and here is how it looks:

https://github.com/boolder-org/boolder-android/assets/8343416/92209abe-1bd0-4267-8030-5d1ed7e7c3fc

I think it is good enough performance wise 😄

nmondollot commented 1 year ago

Great 👍

nmondollot commented 1 year ago

One last thing: the white bar with the area's name looks a bit weird => can you remove it (for now)?

I'll open a new issue to clarify the specs of the top bar when an area is selected

Thanks!

nmondollot commented 1 year ago

Here it is: https://github.com/boolder-org/boolder-android/issues/37

wang-li commented 1 year ago

One last thing: the white bar with the area's name looks a bit weird => can you remove it (for now)?

As this PR was already merged, I directly implemented the specs from #37 in another PR #40