boolder-org / boolder-android

Boolder Android app https://www.boolder.com/en/app
MIT License
28 stars 12 forks source link

Area bar adjustments #40

Closed wang-li closed 1 year ago

wang-li commented 1 year ago

According to #37 the area bar should be positioned on the search bar.

https://github.com/boolder-org/boolder-android/assets/8343416/ee7c8c7c-8714-4a13-9372-1fa0b9cffbe0

The zoom threshold of 15 was out of sync with the map content change, so I kept it to 14.5. Just tell me if you think the threshold value should be synced to 15 instead of 14.5.

Resolves #37

nmondollot commented 1 year ago

Great! 🥳

A few things:

1/ The search doesn't seem to work anymore 🤕

2/ Can you use a slightly larger font size for the area's name? Maybe the same as the search placeholder to stay consistent?

3/ Small bug: when mapbox data isn't loaded yet (eg: at first start) and I tap on an area's hull, the area detector doesn't work

https://github.com/boolder-org/boolder-android/assets/330823/a51bdc7b-ba4d-4e34-9915-ac07e578164d

Possible solution: set the area manually when user taps on an area

Note: same thing when :

nmondollot commented 1 year ago

The zoom threshold of 15 was out of sync with the map content change, so I kept it to 14.5. Just tell me if you think the threshold value should be synced to 15 instead of 14.5.

Ok let's keep 14.5 👍

wang-li commented 1 year ago

1/ The search doesn't seem to work anymore 🤕

Oops my bad, I was too focused on testing the display on the area itself 😅

2/ Can you use a slightly larger font size for the area's name? Maybe the same as the search placeholder to stay consistent?

This should be consistent now. I also set the text to a single line with an ellipsis if it gets too long

3/ Small bug: when mapbox data isn't loaded yet (eg: at first start) and I tap on an area's hull, the area detector doesn't work

This one along with the search should be fixed, as the area name display is triggered by the end of the camera animation. I had to add an animation after selecting an area in the search to make it work

Here is the result on my OnePlus One:

https://github.com/boolder-org/boolder-android/assets/8343416/580f824e-0eff-400b-b63b-9c512ccd10b8

nmondollot commented 1 year ago

Great!

One last thing I noticed: the small bug still happens when I do a search and tap on a problem in the list (i.e. the area name doesn't appear when the map data isn't loaded yet)

Other than that you can go ahead and merge 🚀 I'll probably do a release early next week.

wang-li commented 1 year ago

@nmondollot I added a camera animation on problem selection, coupled to an animation listener that will make the area name being display when selecting a problem from the search 😉