boolean-uk / software-developer

0 stars 0 forks source link

Upgrade all NodeJS projects to current LTS #151

Closed dearshrewdwit closed 1 year ago

vherus commented 1 year ago

@dearshrewdwit test an exercise from fundamentals @vherus test an exercise from backend module Someone to test an exercise from React module

dearshrewdwit commented 1 year ago

Update see: https://discord.com/channels/811981269595324436/943891385696792657/1040295869695664168 for more info

Screenshot 2022-11-10 at 16 29 11

dearshrewdwit commented 1 year ago

It looks like this should work fine so far for simple nodejs projects (i've also separated out the standard/extension workflows)

vherus commented 1 year ago

For my own ref: https://github.com/boolean-uk/js-fundamentals-primitive-data-types/blob/main/.github/workflows/standard-criteria-tests.yml

Move test run commands to package.json instead of using npx in workflow

dearshrewdwit commented 1 year ago

No current problems

Next, will use the tool create-react-app

dearshrewdwit commented 1 year ago

No issues using create-react-app with NodeJS LTS: v18.12.1

vherus commented 1 year ago

Investigate a bot to see if we can automate upgrading the node dep to latest LTS for exercises

chris2733 commented 1 year ago

Checking which repos are correct: Fundamentals control flow Fundamentals objects Fundamentals loops Fundamentals functions 1 Fundamentals functions 2 Soft play

Repos needing workflows: Fundamentals arrays Fundamentals functions 3

Pull requests on these: Fundamentals variables

dearshrewdwit commented 1 year ago

Let's bump up the priority on this so that tomorrow these repos are all resolved.

Repos needing workflows:

Pull requests on these: