search

boombuler / led

golang package for some LED HID devices
MIT License
23 stars 13 forks source link

prefer SetColor(black) outside the Close() method #3

Closed nitram509 closed 9 years ago

nitram509 commented 9 years ago

I'm working on a command line tool, that is able to control LEDs, using your library. As it is a command line tool, it's expected that setting a color is durable even after the process has finished. Currently the led lib sets the color to Black, when the resources are freed/closed.

That's why I've pulled the SetColor(color.Black) call out of the Close() method. I think this is better because:

I'm aware that this changes current behavior. That's why I've added some detail in README file.

Any thoughts/feedback?

boombuler commented 9 years ago

Hi,

please have a look at https://github.com/boombuler/led/commit/72bca570d19c18ca0ff94c5cf81fc5c967aeaba0

I've added a "SetKeepAlive" method to the device interface and did some cleanup since your pull request showed me that such things need to be changed at to many lines :)

I prefer this because at least one device can't be let active after closing it. Since the busylight needs communication at least every 30 seconds and with the new method you can react to this behavior and my changes doesn't break current code.

I hope it works for you :)

Regards Florian

nitram509 commented 9 years ago

Great. I'll give it a try, now.