search

boomerang-io / charts

Helm charts for Boomerang Projects
Apache License 2.0
3 stars 5 forks source link

Helm chart incorrect references eventing.nats. instead of eventing.jetstream #50

Closed tlawrie closed 2 years ago

tlawrie commented 2 years ago

Describe the bug Helm chart may have incorrect references eventing.nats. instead of eventing.jetstream

To Reproduce

  1. Look at the configmap in the Flow chart

Screenshots image

tlawrie commented 2 years ago

It may correct but not entirely sure.

corcoja commented 2 years ago

Hey @tlawrie, I've split eventing-related properties into two sub-categories:

  1. eventing.nats.* – these are properties for the NATS server itself, things like the URL/URLs of the server/servers, reconnect time, maximum reconnect attempts, etc.
  2. eventing.jetstream.* – Jetstream related properties (independent of the NATS server properties). Through these you can configure the Streams and Consumers used by the services.

I'm open to suggestions to use a different naming scheme 🙂

tlawrie commented 2 years ago

Ah. Makes sense.

Typically in the past we have made sure to reference everything with the same prefix. i think that's fine here as the helm chart values.yaml is still trying to achieve that and make it easier for the end user, its only in the configmap.