search

boomerang-io / charts

Helm charts for Boomerang Projects
Apache License 2.0
3 stars 5 forks source link

add hostAlias section to data loader #59

Closed gchickma closed 2 years ago

gchickma commented 2 years ago

Add hostAlias section to data loader

tlawrie commented 2 years ago

This is probably a Flow 3.8.0 change as it's not been verified in all the Flow 3.7.0 changes so far.

gchickma commented 2 years ago

Change is very minor, i.e. it includes an optional hostAlias block to the loader pod descriptor. Have tested it in other charts similar to Flow and works as expected. If it can be merged in I am happy to test as part of 3.7.0.

tlawrie commented 2 years ago

My preference is that it waits until 3.8.0 as 3.7.0 has been in draft release for 2 weeks awaiting on one front end tag. However, we now have multiple chart and worker tags that are trying to be added with creep in the release scope.

However, if it was agreed in the community meeting, then we can add but we would need the documentation updated ASAP and README updated.

tlawrie commented 2 years ago

Also has it been tested

The TLS change required two last-minute emergency fixes in release shakeout so im trying to make sure that we don't ship with a faulty install.

gchickma commented 2 years ago

There's no documentation currently for hostAliases in the README.md I will add a new section

gchickma commented 2 years ago

Wrt testing, yes to all for similar chart, no to Flow as it hasn't been merged and packaged as yet

gchickma commented 2 years ago

Updated chart pushed

gchickma commented 2 years ago

Thx @morarucostel @tlawrie for the reviews. Please let me know when we can merge this PR. Thx.

timrbula commented 2 years ago

@gchickma With the two approvals, lets merge this in?