search

boomerang-io / charts

Helm charts for Boomerang Projects
Apache License 2.0
3 stars 5 forks source link

add support for Instana and switch New Relic to use enable flag like … #62

Closed gchickma closed 2 years ago

gchickma commented 2 years ago

Add support for Instana. Only app configuration required - Instana auto discovers all services.

Also switch New Relic to use enable flag like all other monitoring options

timrbula commented 2 years ago

@morarucostel Can you take a look at this when you have a moment? It closes #61

gchickma commented 2 years ago

@tlawrie I've made further updates for Instana and New Relic configuration. Please take a look when you can. Thx.

tlawrie commented 2 years ago

Hi @gchickma I have already approved this and GitHub isn't showing any new changes.

Screen Shot 2022-03-29 at 10 41 23 am
timrbula commented 2 years ago

@gchickma to follow up on the above, when you return can you make sure that your changes pushed to the remote?

gchickma commented 2 years ago

@timrbula All my changes are on remote branch - I see the changes here https://github.com/boomerang-io/charts/pull/62/files

Does it just need a 2nd review from @morarucostel ?

tlawrie commented 2 years ago

hey @gchickma. We were on the community call trying to figure out why you were asking for a review. We thought you must have thought you pushed additional changes that needed review.

If there are no new changes, this PR already has my approval. You may need @morarucostel to approve as well?