search

boomerang-io / charts

Helm charts for Boomerang Projects
Apache License 2.0
3 stars 5 forks source link

Helm chart does not work with latest NGINX Ingress Controller and Kube 1.22+ #64

Closed tlawrie closed 2 years ago

tlawrie commented 2 years ago

Testing this in AKS 1.22+ with Ingress Controller 1.2.0

With Kube 1.22 and above, the kubernetes.io/ingress.class: annotation has been deprecated and replaced with .spec.ingressClassName which was introduced in 1.18 or 1.19

Additionally, in AKS (not sure if this holds true for elsewhere), as the annotation has been deprecated, you now need to put nginx in the ingress annotation prefix to make nginx.ingress.kubernetes.io

tlawrie commented 2 years ago

@gchickma @morarucostel I have created a PR for review.

tlawrie commented 2 years ago

@morarucostel what are your thoughts on removing the API capabilities check? and also on removing the deprecated annotation?

Do we need to remain backwards compatibility with prior to Kube 1.19?

tlawrie commented 2 years ago

This would be similar to other open source projects but also Tekton which every couple of releases will deprecate earlier Kubernetes support.

image

tlawrie commented 2 years ago

Hey @morarucostel @gchickma bump.

I think we should go ahead and remove compatability support for anything prior to Kube 1.20 - which in itself was end of life 2022-02-18 https://kubernetes.io/releases/