Manual Approval task is missing the specifics on the configuration page

boomerang-io / community

The Boomerang community, roadmap, planning, and architecture repository. The central place for information on joining, contributing, and governance.

https://useboomerang.io

Apache License 2.0

11 stars 0 forks source link

Manual Approval task is missing the specifics on the configuration page #341

Closed morarucostel closed 2 years ago

morarucostel commented 2 years ago

Describe the bug

Trying to use the Manual Approval task in a workflow, doesn't allow the end-user to configure its specifics, like the question being asked.

What project does this issue relate to?

Boomerang Flow

To Reproduce

create a workflow
drag&drop the Manual Approval task
edit the task

Environment

Browser: Firefox
Flow version: 3.8.0

Additional Contenxt

No response

timrbula commented 2 years ago

@amhudson @tlawrie

~This is not a front-end bug. The response coming from the service has an empty config array that determines what is rendered in the "specifics" section~

Nvm I can't read

timrbula commented 2 years ago

In the FE code we have a check to show the inputs for the number of approvals and approver group

isTeamScope && approverGroupsData so if you are trying to use a manual approval task in a system or team scope workflow it is not going to show anything. Is that the desired behavior?

timrbula commented 2 years ago

Closed w/ a short term solution. Need to open up something larger around approvals for all scopes.