search

boomerang-io / community

The Boomerang community, roadmap, planning, and architecture repository. The central place for information on joining, contributing, and governance.
https://useboomerang.io
Apache License 2.0
11 stars 0 forks source link

Importing workflow into "My Workflows" area doesn't import the workflow #351

Closed morarucostel closed 2 years ago

morarucostel commented 2 years ago

Describe the bug

Importing a workflow into the "My Workflows" area shows in the UI's notifications area that the import was successfully, however you can not see the imported workflow in the "My Workflows" page.

The workflow is being saved in the database however is missing the "ownerUserId" key, and for that reason it is not loaded up in the "My Workflows" page.

There is no setOwnerUserId in the https://github.com/boomerang-io/flow.service.workflow/blob/e9eefde2448bfa17da9cbf87281d0c61570ee4e1/src/main/java/io/boomerang/service/crud/WorkflowServiceImpl.java#L547

What project does this issue relate to?

Boomerang Flow

To Reproduce

Import a new workflow in the My Workflow area.

Environment

Additional Contenxt

No response

amhudson commented 2 years ago

@morarucostel We do record the OwnerUserId here. I'm not able to replicate. Can you give me the workflow you are trying to import?

morarucostel commented 2 years ago

Hey @amhudson , thanks for picking this one.

The ownerUserId is being populated (as you show in your link) when the workflow that is being imported is already in the database. See the if statement here 

final WorkflowEntity entity = workflowRepository.getWorkflow(export.getId());

if (entity != null) {

However when the imported flow is new, the id is not found in the DB, it goes on the else branch of that if statement.