[charts] `bmrg-flow-apps-flow` ingress definition is invalid

boomerang-io / community

The Boomerang community, roadmap, planning, and architecture repository. The central place for information on joining, contributing, and governance.

https://useboomerang.io

Apache License 2.0

11 stars 0 forks source link

[charts] `bmrg-flow-apps-flow` ingress definition is invalid #358

Closed aiciobanu closed 2 years ago

aiciobanu commented 2 years ago

Describe the bug

bmrg-flow-apps-flow ingress template is invalid. annotations.kubernetes.io/ingress.class and spec.ingressClassName cannot be used at the same time

What project does this issue relate to?

Boomerang Flow

To Reproduce

Have a Kubernetes platform
Deploy bmrg-flow-4.13.3 helm chart

Environment

Kubernetes platforms used:

k3d (k3s versions 1.21 and 1.22)
IBM Kubernetes Service v1.21

Additional Contenxt

No response

tlawrie commented 2 years ago

Hey @aiciobanu I checked with @morarucostel and @gchickma on the removal of the annotation in the last release 3.10. It was determined it was no longer needed to be supported as support for the annotation has been dropped many versions before, and I think has been supported since Kube 1.19 or 1.21

It would be preferable to not have to have support for it.

aiciobanu commented 2 years ago

@tlawrie Closed the first PR and made a new one that removes the annotation