search

boomerang-io / community

The Boomerang community, roadmap, planning, and architecture repository. The central place for information on joining, contributing, and governance.
https://useboomerang.io
Apache License 2.0
11 stars 0 forks source link

Workflow + Engine - Filter out deleted status workflows from the various API calls #397

Closed tlawrie closed 1 year ago

tlawrie commented 1 year ago

We have made the decision to mark Workflows as deleted rather than removing them. This was done as otherwise its hard to render the WorkflowRuns for that workflow.

We could make a decision to show a note that says "this will remove all associated data including activity, if you no longer want it to be runnable, mark this Workflow as inactive instead"

tlawrie commented 1 year ago

@gchickma @timrbula could you comment on the above.

For delete... do we remove the Workflow, WorkflowTokens, WorkflowRuns, TaskRuns, etc i.e. cascade delete.

Or do we mark as 'deleted' status (keeping in mind we have Active, InActive, Deleted). We then need to make the queries based on status i.e. you cant update a deleted Workflow. -> This is mostly implemented as we stand.

What happens in the current 'delete'? is that what the current inactive is used for?