Advanced PVC Configuration

[tlawrie]

Is your request related to a problem? Please describe. Currently workflows are limited to only a single PVC to be enabled for the duration of a single execution with no ability to set the custom size.

Describe the solution you'd like

• Ability to map mounted PVCs for pre-existing PVCs that may have been manually created in the cluster or created by another solution.
• Ability to enable the workspace / workflow PVC
• Ability to set which PVCs are Ready vs Read/Write
• Ability to set custom size on the PVC (this will also need to relate to the quota)

Describe the benefits or justification for this request This will allow much more advanced and dynamic control of how storage / caching / access can be controlled.

Additional context FYI: @simon-harris-ibm

[tlawrie]

The current thinking on the implementation will be to expand the options for a user to

• Toggle for Workspace (or Workflow) Storage
• Current toggle updated as Workflow Activity Storage
• A button for add additional custom storage
  • Allows for name, readOnly, optional (I.e. don't fail if doesn't exist), and mountPath, and size. https://tekton.dev/docs/pipelines/workspaces/

[tlawrie]

@BenjaminRuby To start with the only changes are on the Workflow > Configure tab change the title from Other Options to Storage Options.

[tlawrie]

[tlawrie]

@marcusdroy @Okisa this is the zenhub for the items being discussed.

I think for now we can solve the

• Mount Path
• Size
• Both workspace and workflow

The ability to specify custom already existing objects (probably create a new zenhub enhnacement request to track that)

[Okisa]

@marcusdroy by now, I updated the props to include size and mountPath for workspace and workflow like this. If there is anything that need to be changed, let me know.

workflowStorage: {
   enabled: boolean,
   size: number,
   mountPath: string,
 },
 workspaceStorage: {
   enabled: boolean,
   size: number,
   mountPath: string,
 },

[Okisa]

@tlawrie currently this is how the modal looks like for Workspace. For Workflow I just need to update the subtitle to the correct content and the tooltips (don't have much idea of the difference from them).

[tlawrie]

Hey @Okisa great question.

The main difference is that Workspace storage persists across workflow executions, where as Workflow storage is per execution.

For the description in the modal, you could say something like;

Workflow storage is persisted per workflow execution and allows you to share short-lived artifacts between tasks in the workflow. Note: All artifacts will be deleted at the end of the workflow execution. If you want to persist long term use Workspace storage.

And for Workspace, could you update to;

Workspace storage is persisted across workflow executions and allows you to share artifacts between workflows, such as maintaining a cache of files used every execution. Note: use with caution as this can lead to a collision if you are running many executions in parallel using the same artifact.

[tlawrie]

Hey @Okisa further changes to close out

Configuration Page

1. We have renamed it to Workspaces (instead of Storage Options)

2. Update the description / copy

   Workspaces allow your workflow to declare storage options to be used at execution time. This will be limited by the Storage Capacity quota which will error executions if you exceed the allowed maximum.

3. We have renamed the Enable Workspace Peristent Storage to Enable Workflow Persistent Storage (yes i know thats a bit confusing... sorry)

4. We have renamed the Enable Workflow Persistent Storage to Enable Activity Persistent Storage

Workflow Modal For the configure modal of the new Workflow Persistent Storage I have updated the

• Title
• Description
• Helper text for Size -> don't do this change even though its in the image.
• Default value for Mount Path
• Helper Text for Mount Path Also, is there a better mechanism than the text box for Storage Size? we will know the maximum value (based on quota). Is a slider useful here or does carbon have a particular mechanism?

Activity Modal Similar changes. See photo.