Open tlawrie opened 1 month ago
We alos have to update the various implementations of this conversion.
Its done at canvas and tekton conversion time in multiple different ways.
Once this change is made, will need to re-validate the secure params as well.
@timrbula if you could review the above and have a think about the two types that only partially match. As well as whether we should do a merged object or not.
Option for a Merged Schema
"params": [
{
"name" : "secret",
"type" : "string",
"description" : "",
"default" : "",
"config": {
"key" : "secret", //this could be removed in favour of param.name
"description" : "", //this could be removed in favour param.description
"label" : "My Secret Password",
"type" : "password", //this **could** become config.element
"required" : false,
"placeholder" : "",
"helperText" : "",
"minValueLength" : "",
"maxValueLength" : "",
"language" : "",
"disabled" : "",
"defaultValue" : "", ///this could be removed in favor of param.default
"value" : "",
"values" : "", //not sure what this is used for
"readOnly" : false,
"hiddenValue" : false,
"options" : [
{
"key" : "asdads",
"value" : "asdads"
},
]
}
},
...
]
Benefits
Drawbacks
Two remaining concerns with the current params and config implementation
Potential Solutions Store config in the annotations, or merge with an extended params that can then be easily whittled down for the tekton params. If merging, then config.type could become element as its the UI element to be rendered.
References