Workflow + Engine - Add ability to change TaskRun Timeout as user/team

boomerang-io / flow.service.workflow

The backend for front-end microservice for Boomerang Flow, a no-code, cloud-native workflow automation tool. Built in Java using Sprint Boot

https://useboomerang.io

Apache License 2.0

6 stars 8 forks source link

Workflow + Engine - Add ability to change TaskRun Timeout as user/team #131

Open digglife opened 2 years ago

digglife commented 2 years ago

Is your request related to a problem? Please describe.

There is a setting for Flow administrator to change the Timeout of TaskRun, which is now by default 180 minutes. If user's flow needs longer than 180 minutes to complete, he has to ask Administrator to change it.

Describe the solution you'd like

Allow users to customize the Timeout of TaskRun.

Describe the benefits or justification for this request

Users can help themselves adjust the timeout, without asking the administrator.

tlawrie commented 2 years ago

Hi @digglife its a great question. We have another enhancement that talks about advanced configuration for tasks where you could specify time outs or no network access or secrets and more.

But w.r.t. timeout would be a great addition but does pose security concerns in that you wouldn't want a user to set a task with 24hour timeouts as that could mess up the cluster if too many were run with that sort of timeout.

What would probably need to happen is a quota introduced for timeout, with a default specified timeout. And then a user could adjust within the quota. OR maybe the workflow timeout overall will kill any tasks that exceed the whole workflow timeout.

tlawrie commented 2 years ago

@BenjaminRuby to check with @gchickma on the importance for IBM in this.

For now bumping this from 3.8.0

tlawrie commented 1 year ago

This is available in v4 both at a WorkflowRun and TaskRun level.

Needs to be added to the UI to make available. Tagged for Flow 4.0.0

tlawrie commented 10 months ago

@timrbula we need to add the timeout and retries fields to the Workflow / Tasks. Considering right now in the UI its hard to edit each task's configuration... for now we should add to the Workflows config screen

Future state might be to add a tab to the Tasks modal or move that to a right hand panel

tlawrie commented 7 months ago

This has been implemented for the Workflow and is linked to Quotas.

Need to implement specific settings per task somehow

tlawrie commented 2 months ago

Implemented via the API

Could be implemented a couple of different ways in the UI

Part of the tasks edit modal with tabs
New modal with a configure / settings button added to the draggable task
Only on the code editor view for the Workflow