search

boomerang-io / flow.service.workflow

The backend for front-end microservice for Boomerang Flow, a no-code, cloud-native workflow automation tool. Built in Java using Sprint Boot
https://useboomerang.io
Apache License 2.0
7 stars 8 forks source link

Cleaned code and handled some NPEs that may occur #205

Closed AndreiOla closed 2 years ago

AndreiOla commented 2 years ago

Changed

I removed try-catch blocks for 'general' Exceptions. I think those were RuntimeExceptions, because there were unhandled null values. Did some minor code logic changes, since there were made unnecessary operations. I also removed parameters not used and a 'throws Exception'.

tlawrie commented 2 years ago

Hey @AndreiOla can you create a matching issue and attached to the appropriate release on the Flow GitHub Project?

Also will need @marcusdroy to review PR.

amhudson commented 2 years ago

@AndreiOla is this ready to review again or are you still working?

AndreiOla commented 2 years ago

@amhudson It is ready for review.

tlawrie commented 2 years ago

Hi @amhudson @AndreiOla is this ready for review?

AndreiOla commented 2 years ago

Hi @tlawrie . Yes it is.

tlawrie commented 2 years ago

Completed a peer review with @amhudson on the Boomerang community call. Only two discussions points to be addressed and, depending on those, can be merged in.