boomerang-io / flow.service.workflow

The backend for front-end microservice for Boomerang Flow, a no-code, cloud-native workflow automation tool. Built in Java using Sprint Boot
https://useboomerang.io
Apache License 2.0
7 stars 8 forks source link

Workflow service – Produce CloudEvents with workflow status #210

Closed corcoja closed 1 year ago

corcoja commented 2 years ago

Part of feature request boomerang-io/roadmap#326

Update workflow service to produce CloudEvents when the status of a workflow changes

Changelog

New

Changed

Removed

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [70871](https://dashboard.gitguardian.com/incidents/70871?occurrence=40897130) | Generic High Entropy Secret | 82443ad85fd21be5a0ab33eae85b978fb2c246de | src/test/java/io/boomerang/tests/controller/WorkflowControllerTests.java | [View secret](https://github.com/boomerang-io/flow.service.workflow/commit/82443ad85fd21be5a0ab33eae85b978fb2c246de#diff-21bee54e54648f2c37dca1b2cfa30ec0d2a0e9b6602d2e129306e8366acae6c2L217) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

tlawrie commented 1 year ago

Hey @corcoja can we get the change log at the top of the PR split into Eventing changes vs General changes as there are 47 files touched but I think probably only 15 related to eventing.

This will make it easier to ensure the relevant peices are migrated to v4 (Engine Service)

FYI @gchickma @amhudson

AndreiOla commented 1 year ago

Since the 2 split branches were Merged, I will close this PR.