boomerang-io / flow.service.workflow

The backend for front-end microservice for Boomerang Flow, a no-code, cloud-native workflow automation tool. Built in Java using Sprint Boot
https://useboomerang.io
Apache License 2.0
6 stars 8 forks source link

fix retrieve teams by HLG when externalUserUrl is configured #238

Closed shenqinb-star closed 1 year ago

shenqinb-star commented 1 year ago

Closes #

A defect was found on Core Flow with following configuration: non-admin user always get empty team list

flow.externalUrl.team=
flow.externalUrl.user=${users.base.url}/internal/users/user.

Based on above configurations and code logic, the team Id list is get from flow.externalUrl.user which is mapped to higherLevelGroupId in _flowteam collection, but the code logic is query against _id.

Changelog

Changed

tlawrie commented 1 year ago

Hey @amhudson this looked good to me. Can you add your thoughts?

amhudson commented 1 year ago

Looks good to me also!