Authorize improvements - Githubissues

boomerdigital / solidus_amazon_payments

Add Pay with Amazon to your Spree Commerce solution

Apache License 2.0

7 stars 8 forks source link

Authorize improvements #24

Closed jordan-brough closed 8 years ago

jordan-brough commented 8 years ago

Note: Please ignore the "Better usage of Payment#number" commit. It has its own PR (#22).

It's probably easiest to understand this going through commit by commit.

Main items:

Better error handling for authorizations
Starting switching over to use Amazon's Ruby gem for performing authorize calls.

Secondary item:

Allow using Sandbox Simulations for simulating errors while in Sandbox mode. See code comments.

Also:

Remove some duplicated specs
Refactor amazon_spec.rb a bit

manmartinez commented 8 years ago

@jordan-brough can we rebase this please?

jordan-brough commented 8 years ago

@manmartinez sure thing, I've rebased on the latest master.

jordan-brough commented 8 years ago

@manmartinez just FYI I've got some more stuff in the pipeline building on this that I haven't PR'd yet. When you have a minute to take a look that would be great. Thanks!

manmartinez commented 8 years ago

@jordan-brough I'll try to review this ASAP sorry for the delay but I've been caught up in another project

jordan-brough commented 8 years ago

@manmartinez thanks for the feedback! I've responded to all the comments. Lmk what you think.

It'll be great to get this merged in so we can start swapping out AmazonMws for Amazon's gem!

manmartinez commented 8 years ago

Looks good! :+1: Sorry for the delay, it's been a bit hard finding time to work on this