Limit itemCode to 50 characters

[ericsaupe]

While investigating an issue with our tax responses coming back as bad we received this in the response. We should limit the itemCode field to 50 characters as requested. We should also look into any other fields that have limits.

{
    "error" => {
           "code" => "ModelStateInvalid",
        "message" => "Field 'itemCode' has an invalid length.",
         "target" => "HttpRequest",
        "details" => [
            [0] {
                       "code" => "MaxStringLengthError",
                     "number" => 14,
                    "message" => "Field 'itemCode' has an invalid length.",
                "description" => "Field 'itemCode' must be no more than 50 characters in length.",
                  "faultCode" => "Client",
                   "helpLink" => "http://developer.avalara.com/avatax/errors/MaxStringLengthError",
                   "severity" => "Error"
            }
        ]
    }
}

Affected lines

• https://github.com/boomerdigital/solidus_avatax_certified/blob/0cbfe600c5416c3acf4a7a5e27ad73cc82c9d373/app/models/solidus_avatax_certified/line.rb#L33
• https://github.com/boomerdigital/solidus_avatax_certified/blob/0cbfe600c5416c3acf4a7a5e27ad73cc82c9d373/app/models/solidus_avatax_certified/line.rb#L62
• https://github.com/boomerdigital/solidus_avatax_certified/blob/0cbfe600c5416c3acf4a7a5e27ad73cc82c9d373/app/models/solidus_avatax_certified/line.rb#L100

[dhonig]

Interesting to know what field you used that was longer than 50 chars? Is it safe to limit this to substr(0,49) or do we need to do something else?

[ericsaupe]

For us it was the shipping_method.name. We display the name on the frontend so it allows editing more easily than having it hard coded. Changing to shipping_method.internal_name would have resolved it for us but may still not for others. I used truncate in the patch for our site but that can interfere with items that may be set specifically in AvaTax that are taxing based on itemCode instead of relying on the category.

I think substr or truncate are fine the issue is just to get it down to 50 characters to be in compliance of their API.