Refactor OrderContentsDecorator.add_to_line_item and bump version

boomerdigital / solidus_flexi_variants

BSD 3-Clause "New" or "Revised" License

15 stars 31 forks source link

Closed masonjeffreys closed 6 years ago

masonjeffreys commented 6 years ago

Changes to OrderContentsDecorator.add_to_line_item

Separated incoming options hash into standard spree options, product_customizations, and ad_hoc-option_ids
set line_item.options using standard spree options
separated some logic into new flexi_variants method
flexi_variants method calls new line_item instance methods to assign options and get price adjustments

masonjeffreys commented 6 years ago

@acreilly @dhonig Any thoughts on this?

acreilly commented 6 years ago

Looks good to me! Thanks for doing the work. @dhonig What do you think?

dhonig commented 6 years ago

@kinduff merge it?

masonjeffreys commented 6 years ago

Ping on this. I'd like to keep working on some other parts of this gem as soon as we get this through.

kinduff commented 6 years ago

Looks good to me, great work here