boomerdigital / solidus_flexi_variants

BSD 3-Clause "New" or "Revised" License
15 stars 31 forks source link

More than one customizable product on a page causes issues. #11

Open masonjeffreys opened 6 years ago

masonjeffreys commented 6 years ago

Showing more than one customizable product at a time causes issues like:

The javascript involved on the frontend of the gem should be reworked to be scoped to a single product, rather than the entire dom.

Happy to work on this. Perhaps some direction could be provided. Thanks, Jeff

masonjeffreys commented 6 years ago

@acreilly @dhonig If you're okay with this direction, I will take a first pass at it. I'll try hard to keep it backwards compatible. This would be for customizable options only at this point.

acreilly commented 6 years ago

That would be great. Ping me when you have a PR. Thanks!

masonjeffreys commented 6 years ago

@acreilly Took the first steps and issued a PR. This doesn't get us all the way to allowing multiple products on one page, but it starts us off.

I'd also like to move the front end calculator JS into the asset pipeline, but that's a bigger departure from current status quo. What do you think?

masonjeffreys commented 6 years ago

Sorry to overload the comments. But maybe it would be helpful to list the areas I'd like to help in, and see if they align with your vision:

masonjeffreys commented 6 years ago

@acreilly @dhonig Any thoughts on my last PR or the bullet points in the comment above? Happy to do more work, just want to make sure it aligns with your vision. Thanks!