boomerdigital / solidus_flexi_variants

BSD 3-Clause "New" or "Revised" License
15 stars 31 forks source link

Separate into core, frontend, and backend engines (like Solidus) #2

Closed masonjeffreys closed 6 years ago

masonjeffreys commented 7 years ago

I have been modifying a fork of this gem to separate the solidus_flexi_variants gem into core, frontend, and backend engines. It's a similar format to the solidus path. I went down this path because I wanted to use the models, business logic, and admin views but not the frontend stuff.

In fact, if a person isn't using solidus_frontend, they may not be able to get the existing solidus_flexi_variants gem to work because it depends on standard solidus/spree frontend controllers.

Are you interested in a pull request for this separation? I'll probably need some help to finish it.

dhonig commented 7 years ago

Its probably a good idea. Can you outline the changes?

masonjeffreys commented 7 years ago

I'll give it a shot:

masonjeffreys commented 6 years ago

Closing due to lack of movement. Probably too big of a change without motivation to justify it. Pursuing alternative method of allowing users without solidus frontend to still use this gem.