boomerdigital / solidus_flexi_variants

BSD 3-Clause "New" or "Revised" License
15 stars 31 forks source link

Update gem to pass with v2.8 #20

Closed fastjames closed 4 years ago

fastjames commented 4 years ago

Update the gem to pass under Solidus v2.8. This should provide a good starting point for further updates to support Solidus v2.9 and beyond. Changes made include:

  1. Update TravisCI matrix to remove EOL Solidus versions
  2. Update Rakefile to support standard rake task
  3. Pin sprockets to <4 to avoid new breaking change
  4. Add puma dev dependency for feature specs
  5. Update factory to remove static attribute
  6. Update reference to capybara wait time
  7. Update feature spec to match option text and ordering as observed
dhonig commented 4 years ago

Tests are still failing. Let us know if you need a hand with this.

fastjames commented 4 years ago

Tests are still failing. Let us know if you need a hand with this.

Thanks for the heads-up. I took a look at some other extensions and updated the travis config to be more like those (since they are passing).

fastjames commented 4 years ago

@dhonig some progress -- the only two failing paths now are v2.5 and master.

fastjames commented 4 years ago

It looks like master is failing because the add_class method was removed back in July: https://github.com/solidusio/solidus/commit/d82fb569ab2f4d79181473c35169813ab7c39e35

fastjames commented 4 years ago

The v2.5 path is failing because it times out while running bundle.

fastjames commented 4 years ago

I just pushed a commit that passes locally for master. I didn't test it with other versions yet. Still no idea what's up with v2.5.

fastjames commented 4 years ago

Sorry this has taken so long -- I have not had much luck replicating these CI failures locally. Hopefully moving to selenium and headless chrome will help some of these since they seem to be possible browser-related.

fastjames commented 4 years ago

Let the record show that I have now gotten every branch to pass at least once, just not all on the same run. :rofl:

fastjames commented 4 years ago

I think I have taken too big of a bite here, so I'm going to close this PR and retrench on a more focused branch.

fastjames commented 4 years ago

Continued in https://github.com/boomerdigital/solidus_flexi_variants/pull/22