Closed fastjames closed 4 years ago
Tests are still failing. Let us know if you need a hand with this.
Tests are still failing. Let us know if you need a hand with this.
Thanks for the heads-up. I took a look at some other extensions and updated the travis config to be more like those (since they are passing).
@dhonig some progress -- the only two failing paths now are v2.5
and master
.
It looks like master
is failing because the add_class
method was removed back in July: https://github.com/solidusio/solidus/commit/d82fb569ab2f4d79181473c35169813ab7c39e35
The v2.5
path is failing because it times out while running bundle
.
I just pushed a commit that passes locally for master
. I didn't test it with other versions yet. Still no idea what's up with v2.5
.
Sorry this has taken so long -- I have not had much luck replicating these CI failures locally. Hopefully moving to selenium and headless chrome will help some of these since they seem to be possible browser-related.
Let the record show that I have now gotten every branch to pass at least once, just not all on the same run. :rofl:
I think I have taken too big of a bite here, so I'm going to close this PR and retrench on a more focused branch.
Update the gem to pass under Solidus v2.8. This should provide a good starting point for further updates to support Solidus v2.9 and beyond. Changes made include:
rake
tasksprockets
to <4 to avoid new breaking changepuma
dev dependency for feature specs