boomerdigital / solidus_user_roles

Advanced user roles for Solidus.
http://www.boomerdigital.net
BSD 3-Clause "New" or "Revised" License
17 stars 22 forks source link

keep compatibility with solidus < 2.5 #15

Closed ccarruitero closed 6 years ago

ccarruitero commented 6 years ago

Since this commit, gem is broken for solidus < 2.5.

With this change we keep compatibility with older solidus versions

ccarruitero commented 6 years ago

Aside, Not sure why travis is deactive for pull request?

Personally, I found very useful to know if the proposed changes can broke something in any solidus version before merge.

acreilly commented 6 years ago

I understand, this occurs when the PR is from a forked repo. I am going to merge and can revert if it errors.

ccarruitero commented 6 years ago

Uhmm, I'm sure that travis can do builds for any PR. Take a look at your travis's repository settings, and make sure that the option for build pushed pull requests be marked.