Closed ccarruitero closed 6 years ago
Aside, Not sure why travis is deactive for pull request?
Personally, I found very useful to know if the proposed changes can broke something in any solidus version before merge.
I understand, this occurs when the PR is from a forked repo. I am going to merge and can revert if it errors.
Uhmm, I'm sure that travis can do builds for any PR. Take a look at your travis's repository settings, and make sure that the option for build pushed pull requests
be marked.
Since this commit, gem is broken for solidus < 2.5.
With this change we keep compatibility with older solidus versions