search

boonebgorges / bp-groupblog

BuddyPress Groupblog
GNU General Public License v3.0
15 stars 10 forks source link

Theme Settings Bug #10

Closed mahype closed 2 months ago

mahype commented 12 years ago

Theme have been set, if "groupblog-themes" or "regular-themes" was set. Cleaned up Select Tag in Admin.

mahype commented 12 years ago

Hi Boone! If you need some information of the updates, just ask me! I would be pleased if you would take the changes into your code because update compatibility in future. I hope these changes will get your commitment. Greetings, Sven!

christianwach commented 12 years ago

Hi Boone (hi Sven)

It seems to me that Sven has correctly identified an issue with non-public blogs being accessible to non-members when accessed via their URL rather than the link on the group's page. I'm not convinced that an admin option is necessary for this - a simple redirect to network_site_url() seems logical, with a filter for when a special "access denied" page is required.

I'll be submitting a pull request shortly which covers this issue (I have rewritten Sven's function to make use of the WordPress and BP Groupblog APIs) plus a number of other hiccups which have arisen since the release of WordPress 3.4.

Cheers,

Christian

christianwach commented 12 years ago

Oh, one more little thing... my pull request also fixes Sven's concerns about empty options being selected by using the semantically more appropriate optgroup tag - which is why I am not personally in favour of commit ad49351.

Cheers,

Christian