search

boonebgorges / bp-groupblog

BuddyPress Groupblog
GNU General Public License v3.0
15 stars 10 forks source link

Updates to 1.7.x to make it compatible with WP3.4 #11

Closed christianwach closed 12 years ago

christianwach commented 12 years ago

Hi Boone,

As promised in the comments to mahype's pull request, here's mine which solves all the issues I can find with the plugin under WordPress 3.4.

All the best,

Christian

christianwach commented 12 years ago

Oops, forgot to commit the filter before sending the pull request. You can see the code in my fork at:

https://github.com/christianwach/bp-groupblog/commit/59c20cfef0af850f07c1eca73dd241307c691fa0

Edit: it does seem to have appeared here after all... the magic of GitHub :-)

Cheers,

Christian

boonebgorges commented 12 years ago

I'm working on merging this in. Mostly it looks great. Thanks a million for the fixes and improvements.

I'm not going to include https://github.com/christianwach/bp-groupblog/commit/a09f47a8da56de72e50d54f60666fdebedc0a34f, because there are cases where blogs might be non-public but groupblogs would be public. In the future your code could be added as an option, but I don't want it to be the enforced default.

boonebgorges commented 12 years ago

I've merged everything into the new 1.8.x branch (this version will be 1.8 :) ). Going to close the pull request. Thanks a million for the fixes, and feel free to send more :) I'll release this new version sometime later in the week if I get a chance.

christianwach commented 12 years ago

Thanks Boone, much appreciated.

Agree that redirection ought to be configured via an admin option and will look into that when I have a moment.