search

boonebgorges / bp-groupblog

BuddyPress Groupblog
GNU General Public License v3.0
15 stars 10 forks source link

Enable comment activity recording #44

Closed r-a-y closed 6 years ago

r-a-y commented 6 years ago

This PR enables blog comment activity recording for groupblogs.

I'm doing some workarounds so we can piggyback on what BuddyPress is already doing for recording blog comments (those with the new_blog_comment type) and to utilize the activity API with bp_activity_set_action(), etc.

There are some slight drawbacks to this approach as hacking into BP's code in this manner makes things a little harder to read, due to the applying and removal of certain filters.

There are also limitations such as BuddyPress only recording public blog content: https://buddypress.trac.wordpress.org/ticket/4831#comment:10

But, that's a different issue altogether.

@boonebgorges - Let me know what you think.

boonebgorges commented 6 years ago

I've merged this in the 1.9.x branch. I've left the closures as-is and will add the PHP 5.3+ requirement to the readme. Thanks for working through this one!