version 1..9.3 - Githubissues

boonebgorges / bp-groupblog

BuddyPress Groupblog

GNU General Public License v3.0

15 stars 10 forks source link

version 1..9.3 #53

Open lenasterg opened 1 year ago

lenasterg commented 1 year ago

= 1.9.3 =

Test with WordPress 6.1.1, BuddyPress 10.6 and PHP 8.1
Change arguments order of function groupblog_edit_base_settings()
Change arguments order of function bp_groupblog_get_user_role()
Remove some unnecessary globals
Some coding standards issues

boonebgorges commented 1 year ago

Thanks so much for working on this!

Unfortunately, I just merged a PR last week that does some of these changes: https://github.com/boonebgorges/bp-groupblog/pull/52. So the base branch is 1.9.x.

Could you say more about why you're changing the argument order of these functions? I'm a bit nervous that third-party plugins (such as ones that I may have written for clients - it's hard to remember everything I've done in the last 10+ years!) could be using the old function signature.

lenasterg commented 1 year ago

Hi. @boonebgorges. I changed the argument order in order to make the functions compatible with PHP 8+ https://php.watch/versions/8.0/deprecate-required-param-after-optional

boonebgorges commented 1 year ago

Ah, I see. In that case, it's better to provide default values for the later parameters:

function groupblog_edit_base_settings( $groupblog_enable_blog, $groupblog_silent_add = NULL, $groupblog_default_admin_role = '', $groupblog_default_mod_role = '', $groupblog_default_member_role = '', $page_template_layout = '', $group_id = '', $groupblog_blog_id = NULL ) {