search

boonebgorges / bp-groupblog

BuddyPress Groupblog
GNU General Public License v3.0
15 stars 10 forks source link

Activity filter option #8

Open christianwach opened 12 years ago

christianwach commented 12 years ago

Hi Boone,

I've noticed that the activity filtering dropdown doesn't work, but before I change things, I was wondering about the intention of the code.

bp_groupblog_posts() adds an option with a value 'new_groupblog_post', but no activity ever has that type set. Changing the option value to 'new_blog_post' correctly filters the activity list, but seems like a duplicate of the BuddyPress 'Posts' filter on the sitewide activity page - indeed going there having set the option on the group page makes that the default filter option.

So then, is bp_groupblog_set_group_to_post_activity() supposed to replace the activity type with 'new_groupblog_post'? Or should the groupblog option value be 'new_blog_post'?

Cheers,

Christian

christianwach commented 12 years ago

I've also extended the plugin externally to allow blog comments to show up in the relevant group activity stream. Once I'm clear on the logic, do you want me to include this in the plugin itself - possibly with an admin option to enable/disable?