Closed humanshell closed 11 years ago
Cool. What about an image?
The images (icons) don't appear to be getting pulled from the plugin's /images/icons folder. They're pulled from /wp-content/social-media-icons in our (CAC) repo.
Do you want me to add the icon that I put in our repo to the icons folder of this repo as well?
Yes, please. I want to make sure that the plugin itself has some minimal support.
On 11/20/12 15:58, Dominic Giglio wrote:
The images (icons) don't appear to be getting pulled from the plugin's /images/icons folder. They're pulled from /wp-content/social-media-icons in our (CAC) repo.
Do you want me to add the icon that I put in our repo to the icons folder of this repo as well?
— Reply to this email directly or view it on GitHub https://github.com/boonebgorges/bp-social-media-profiles/pull/4#issuecomment-10572683.
Icon has been added and the pull request automatically updated to show 2 commits. That's pretty cool, I haven't done a lot of pull requests.
Cool, this looks good. Thanks, @humanshell
Awesome. How do we handle the release? Will this get pushed to the plugin repo and I'll do an upgrade in the admin?
I don't think this plugin is in the wordpress.org repo. So go ahead and update your local CAC repo manually.
On 11/20/12 16:27, Dominic Giglio wrote:
Awesome. How do we handle the release? Will this get pushed to the plugin repo and I'll do an upgrade in the admin?
— Reply to this email directly or view it on GitHub https://github.com/boonebgorges/bp-social-media-profiles/pull/4#issuecomment-10573847.
Understood. I will paste the relevant commit in the associated Redmine ticket.
Boone,
I've added what I believe is all the code necessary to support academia.edu profile links. Your plugin structure made it unbelievable easy. :-)
I've also added the appropriate icon to the CAC repo.