search

boonebgorges / bp-social-media-profiles

Customize and streamline the display of BuddyPress profile fields related to other social media sites
21 stars 7 forks source link

Add Academia.edu profile support #4

Closed humanshell closed 11 years ago

humanshell commented 11 years ago

Boone,

I've added what I believe is all the code necessary to support academia.edu profile links. Your plugin structure made it unbelievable easy. :-)

I've also added the appropriate icon to the CAC repo.

boonebgorges commented 11 years ago

Cool. What about an image?

humanshell commented 11 years ago

The images (icons) don't appear to be getting pulled from the plugin's /images/icons folder. They're pulled from /wp-content/social-media-icons in our (CAC) repo.

Do you want me to add the icon that I put in our repo to the icons folder of this repo as well?

boonebgorges commented 11 years ago

Yes, please. I want to make sure that the plugin itself has some minimal support.

On 11/20/12 15:58, Dominic Giglio wrote:

The images (icons) don't appear to be getting pulled from the plugin's /images/icons folder. They're pulled from /wp-content/social-media-icons in our (CAC) repo.

Do you want me to add the icon that I put in our repo to the icons folder of this repo as well?

— Reply to this email directly or view it on GitHub https://github.com/boonebgorges/bp-social-media-profiles/pull/4#issuecomment-10572683.

humanshell commented 11 years ago

Icon has been added and the pull request automatically updated to show 2 commits. That's pretty cool, I haven't done a lot of pull requests.

boonebgorges commented 11 years ago

Cool, this looks good. Thanks, @humanshell

humanshell commented 11 years ago

Awesome. How do we handle the release? Will this get pushed to the plugin repo and I'll do an upgrade in the admin?

boonebgorges commented 11 years ago

I don't think this plugin is in the wordpress.org repo. So go ahead and update your local CAC repo manually.

On 11/20/12 16:27, Dominic Giglio wrote:

Awesome. How do we handle the release? Will this get pushed to the plugin repo and I'll do an upgrade in the admin?

— Reply to this email directly or view it on GitHub https://github.com/boonebgorges/bp-social-media-profiles/pull/4#issuecomment-10573847.

humanshell commented 11 years ago

Understood. I will paste the relevant commit in the associated Redmine ticket.