search

boonebgorges / buddypress-docs

GNU General Public License v3.0
106 stars 44 forks source link

Make the "up one folder" link click target larger #515

Closed dcavins closed 8 years ago

dcavins commented 8 years ago

At the moment, the "up one folder" link target is the text: ..

We could give that link a minimum size or change the text to say "go up one folder" or something so there's a bigger click target.

boonebgorges commented 8 years ago

I'd prefer to force the link to be larger using CSS. The '..' text is, I think, pretty standard UX for folder structures. For better accessibility, we could add a .screen-reader-text span.

On 03/07/2016 02:57 PM, David Cavins wrote:

At the moment, the "up one folder" link target is the text: ..

We could give that link a minimum size or change the text to say "go up one folder" or something so there's a bigger click target.

— Reply to this email directly or view it on GitHub https://github.com/boonebgorges/buddypress-docs/issues/515.

dcavins commented 8 years ago

I think we're both used to seeing '..' because we use Unix. :) Windows uses an up arrow, and both Mac and Windows use a "back" button. Windows also features the breadcrumbs as a navigational aid, and they're available in OS X, but you have to turn that view on (it's off by default).

Happily, the browser has a back button, and you've already built the breadcrumb navigation, so I think those bases are covered.

This changeset enlarges the click area and adds the screen reader text, which is a great idea:https://github.com/dcavins/buddypress-docs/commit/ae07d14e98932c4d97b32ba2bd09eee0e898063f

boonebgorges commented 8 years ago

Looks good.

On 03/08/2016 09:25 AM, David Cavins wrote:

I think we're both used to seeing '..' because we use Unix. :) Windows uses an up arrow, and both Mac and Windows use a "back" button. Windows also features the breadcrumbs as a navigational aid, and they're available in OS X, but you have to turn that view on (it's off by default).

Happily, the browser has a back button, and you've already built the breadcrumb navigation, so I think those bases are covered.

This changeset enlarges the click area and adds the screen reader text, which is a great idea:dcavins@ae07d14 https://github.com/dcavins/buddypress-docs/commit/ae07d14e98932c4d97b32ba2bd09eee0e898063f

— Reply to this email directly or view it on GitHub https://github.com/boonebgorges/buddypress-docs/issues/515#issuecomment-193823304.

dcavins commented 8 years ago

Fixed in https://github.com/boonebgorges/buddypress-docs/commit/9749de67d87c4c579e4a836e4a3b5417cfb3e050