Open sarjona opened 8 years ago
Thank you so much for the pull request! I love the functionality.
A couple questions. First, there are some merge conflicts that are arising, primarily because you are working off of master
rather than the latest release branch. (Sorry for not having better documentation of this.) If it's not too much trouble, could you regenerate the PR using the 2.0.x
branch? I think the following should do it:
$ git checkout WIP-multitag
$ git checkout -b WIP-multitag-backup
$ git branch -D WIP-multitag
$ git checkout -b WIP-multitag upstream/2.0.x # replace "upstream" with whatever you've called my repo
$ git cherry-pick 5db0b56
$ git push --force origin WIP-multitag
Github should recognize that you're using the same branch name, and update this PR. (If you can't do all of this, we can continue to work off of the current PR.)
On the substance of the PR:
Thanks!
Hi! It's great that you like this functionality! We have recreated the WIP-multitag branch from the last content of 2.0.x branch, we have adapted the strings with your proposal and we have modified the spacing mistakes. So, the WIP-multitag now has to be correct... Please, tell us if you can merge from this PR or if you need we make a new one. Kind regards!
By default the code of this module supports more than one tag separated by comma (bpd_tag=tag1, tag2), but it's not possible to select more than one from the filtering page. This patch lets select more than one tags when filtering: