search

boonebgorges / buddypress-docs

GNU General Public License v3.0
106 stars 44 forks source link

replace basename() with wp_basename() #581

Closed staude closed 6 years ago

staude commented 7 years ago

replaced basename() with wp_basename(() calls for multibyte character path handling. see https://core.trac.wordpress.org/ticket/21217

dcavins commented 6 years ago

@boonebgorges This seems like it should be OK. Do you know of any issues with that function? wp_basename(): https://core.trac.wordpress.org/browser/tags/4.8/src//wp-includes/formatting.php#L4759

boonebgorges commented 6 years ago

No, I think this seems like an OK change.