search

boonebgorges / buddypress-docs

GNU General Public License v3.0
106 stars 44 forks source link

'There are no docs for this view...' message confusing in nested folders #596

Closed boonebgorges closed 6 years ago

boonebgorges commented 6 years ago

Folders that contain no docs, but contain other folders, get the message: There are no docs in this context.... This feels confusing. For a client, I've removed it: the message only shows if the folder (or top-level group context) is truly empty - no docs and no folders. @dcavins Do you have an opinion about whether this change makes sense in buddypress-docs itself?

dcavins commented 6 years ago

I think that sounds like a good change (showing the message only if the folder/view really has no contents). 👍

boonebgorges commented 6 years ago

Cool, let's do it.

dcavins commented 6 years ago

How about this: https://github.com/dcavins/buddypress-docs/commit/6f6b7bcb974f1c6738ebe73ab58b8eccec942e82

boonebgorges commented 6 years ago

Yes!