search

boonebgorges / buddypress-docs

GNU General Public License v3.0
106 stars 44 forks source link

Remove html markup from gettext string. #598

Closed dcavins closed 6 years ago

dcavins commented 6 years ago

This appears to be the root of the issue here: https://wordpress.org/support/topic/cant-create-document-since-update/#post-9787214

I think this is the right way to fix it, but would like a second opinion. :)

dcavins commented 6 years ago

That's funny. I don't think it's used after all. The warning that pops up after you've lost control of the edit state is in #still_working_content. Should we just remove #idle-warning?

boonebgorges commented 6 years ago

Sure, if you can confirm that it's not used.

dcavins commented 6 years ago

Well, all roads lead back to onIdle() here: https://github.com/boonebgorges/buddypress-docs/blob/2.0.x/includes/js/bp-docs.js#L238 and it refers to #still_working_content. Searching the code for idle-warning or idle-warning-time doesn't turn anything up. It's looking like it's not used.

dcavins commented 6 years ago

Resolved via 2ba26192d204bf8db4410f2d0e635a56688b1550.