search

boonebgorges / buddypress-docs

GNU General Public License v3.0
106 stars 44 forks source link

Directory tab support for Nouveau. #625

Closed boonebgorges closed 6 years ago

boonebgorges commented 6 years ago

This commit moves tab markup into template files. Separate template files are included for Nouveau and Legacy.

See #622.

@dcavins What do you think of this technique?

dcavins commented 6 years ago

@boonebgorges I think this is a nice approach. I'm guessing other template parts will ultimately be forked as we use Nouveau more, too. I'm glad to see an easy-to-follow logic example we can apply to other template pieces as needed.

I've added a commit that applies a missing button style to the "create" button on the main directory, so that it looks more like the "in BuddyPress" directories:

profile-v-main-docs-library-navs

Thanks!

dcavins commented 6 years ago

Oh, and I was amazed that bp_get_theme_package_id() was added way back in BP1.7. That was some impressive forethought on somebody's part!

boonebgorges commented 6 years ago

Excellent, thanks! Let's merge it.