search

boonebgorges / buddypress-docs

GNU General Public License v3.0
106 stars 44 forks source link

Table display of revisions selection fails in some themes. #634

Open dcavins opened 6 years ago

dcavins commented 6 years ago

The way we're declaring widths on the post-revisions table does not appear to work with some themes. code: https://github.com/boonebgorges/buddypress-docs/blob/2.1.x/includes/addon-history.php#L409 revisions-table

According to Mozilla, most of the <colgroup> attributes have been deprecated or are obsolete as of HTML5: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/col

Nevertheless, if I change the column declarations to something like this:

<colgroup>
    <col>
    <col>
    <col width="35%">
    <col width="30%">
    <col width="20%">
</colgroup>

The result is much better: table-revisions-2

However, I'm thinking that adding classes to the columns and applying widths via css would be the better answer (because it would be easier for end users to overrride--rather than hard-coded widths in a function).

Boone, do you have an opinion?

Thanks!

dcavins commented 6 years ago

The actual diff table could be improved, too: diff-table

boonebgorges commented 6 years ago

This was all copied directly out of a version of WordPress several years ago, so I have no objection to changing it to whatever looks better!