search

boonebgorges / buddypress-docs

GNU General Public License v3.0
106 stars 44 forks source link

Widget context options #651

Closed dcavins closed 5 years ago

dcavins commented 5 years ago

Hi Boone, here's a thought at making the BP Docs Recent Docs widget internal logic more obvious at least to the individual who is setting up the widgets.

I think this could be useful now that BP Nouveau has introduced a widget area on group and user profile home pages--so it is easy to show only a group's docs or user's docs, without having to know how to add a filter.

boonebgorges commented 5 years ago

Sure, this seems like a good improvement.

I wonder if we could simplify the settings somewhat by having a single checkbox "Context sensitive" or something like that, which would toggle both group- and user-awareness. Part of me thinks that it's a bit easier to say that if the box is checked, the list of Docs will match the current page, rather than having separate checkboxes for groups and users. (Plus, it seems quite unlikely that you'd want context-sensitivity in one case but not the other.) But I could go either way on this. What do you think?

dcavins commented 5 years ago

Having one checkbox that enables context sensitivity seems like enough to me, too. See https://github.com/dcavins/buddypress-docs/commit/51253ad82748da51a16dc4b695f9656298df3c02

for a combined option.

Thanks!

boonebgorges commented 5 years ago

Yup, that seems good to me. Thanks for working on it!

dcavins commented 5 years ago

Excellent. I've merged the change in https://github.com/boonebgorges/buddypress-docs/commit/8ac86b9b31f18ca1f4dacfa5c1d5f7de2009f32b

Thanks!