boonebgorges / buddypress-docs

GNU General Public License v3.0
105 stars 44 forks source link

Update calls to "_wp_post_revision_field_$field." #726

Closed dcavins closed 1 year ago

dcavins commented 1 year ago

Update filter calls to "_wp_post_revisionfield$field" to add the third and fourth parameter. WP 6.3 added a new filter via a new footnotes block (https://core.trac.wordpress.org/changeset/56298) that requires the third parameter (the WP_POST object), which breaks the apply_filters() call in BP Docs. This change adds the third (the WP_POST object) and fourth (the context of whether the current revision is the old or the new one) parameter. In our setup, the left revision is always the older version, and the right revision is the newer save.

This new problem was reported here: https://wordpress.org/support/topic/bug-revision-comparison-causes-fatal-error-since-wordpress-6-3/

boonebgorges commented 1 year ago

Good sleuthing! Changes look good.