search

boonebgorges / buddypress-docs

GNU General Public License v3.0
106 stars 44 forks source link

Improved content width for CPT pages in certain themes #731

Closed boonebgorges closed 6 months ago

boonebgorges commented 8 months ago

BP pages use the full width styles on certain WP themes. For example, a group page running twentytwentyone:

Screenshot_2023-10-26_20-50-50

In contrast, Docs CPT pages have a very limited width:

Screenshot_2023-10-26_20-51-27

Is there some change we can make to the markup of our CPT pages, perhaps a certain wrapper class or something, that will cause them to use the same width declarations as BP pages? Or perhaps we need to have our own theme-specific fixes like BP does? Possibly related: #730

@dcavins Maybe you could take a moment thinking about this?

dcavins commented 8 months ago

Hi Boone, I'd be happy to look at this. Should PRs be made against the 2.2 branch?

boonebgorges commented 8 months ago

Thanks, David! Yes, the 2.2 branch should be fine. I'm working on a special BP 12 compatibility branch, but I can't imagine it'll conflict much with theme-related changes.

dcavins commented 8 months ago

With the update, in Twentytwenty (similar in '19, '20 and '21): wide-docs-directory

boonebgorges commented 7 months ago

Moving to the 2.2.1 milestone as work is happening in the #738 branch that affects this.

boonebgorges commented 6 months ago

There's more work to be done here with specific themes. See https://github.com/boonebgorges/buddypress-docs/issues/728#issuecomment-1863753818. But let's go with what we've got for 2.2.1.