search

boonebgorges / buddypress-docs

GNU General Public License v3.0
106 stars 44 forks source link

is_home() returning true on most single group pages #757

Open r-a-y opened 2 weeks ago

r-a-y commented 2 weeks ago

On BuddyPress 14.0.0 and with the latest version of BuddyPress Docs, is_home() is returning true on most single group pages except bbPress. If I deactivate BuddyPress Docs, is_home() returns false on these pages.

The furthest I traced this to is this line:

https://github.com/boonebgorges/buddypress-docs/blob/546d95a62b933eca9e9fa0360157945bf0d0c491/includes/component.php#L224

If I comment out this line, is_home() returns false again as expected. That's as far as I got. Hopefully that gives you some pointers! Let me know if I can help debug or test.

boonebgorges commented 2 weeks ago

Hi @r-a-y - Thanks for the report! I'm trying to reproduce but I'm unable to do so on a vanilla installation.

On a hunch, I checked on the CUNY Academic Commons and was able to reproduce. I bisected that change back to some recent mods made to the sitemap routine. This is described in https://redmine.gc.cuny.edu/issues/20860.

I believe that the commented-out line you describe above works, in part, because it breaks Docs - this value of post_type_name is used broadly throughout the plugin. I didn't dig deeper into the relationship between the BP Docs access query and is_home(), but perhaps it's a moot question if I'm right that this is specific to the way the Commons works.