search

boonebgorges / buddypress-group-email-subscription

Fine-grained email subscription for activity in BuddyPress groups
35 stars 31 forks source link

Translation string issue with 'Email Options', translation not shown #205

Closed per4mance closed 3 years ago

per4mance commented 3 years ago

Hello, It seems the translation string of tab and left menu of a group, here 'Email Options', is still in English although I translated it into German. Please see the attached screenshots:

Any help is great, thank you :-)

image

image

christianlersch commented 3 years ago

I had the same Problem, then I see that there is the string "email options" two times in the translation file. :-( And then I see that more strings are double in the file and my POT file is out of date.

I sync my own POT File with the newest POT file from the Plugin and find many more translations that need to be translated. I search a long time for that problem. I also have it in other plugins. Updated POT files in Plugins and own POT files need to be checked on every Plugin Update. ;-(

boonebgorges commented 3 years ago

Could someone please share .po and .mo files that illustrate the problem, so that I can test?

per4mance commented 3 years ago

Sure, I'm going to send it to your email.

per4mance commented 3 years ago

Please check your Gmail ;-)

boonebgorges commented 3 years ago

It looks like there was a problem with the order in which various parts of the BPGES system were loaded, such that parts of the Group Extension (which powers the 'Email Options' nav item) was loaded before the plugin translations. I've just pushed a change, which you can manually apply to your system to verify the fix. See 9edcd1c.

boonebgorges commented 3 years ago

@per4mance Thanks for confirming the fix. This will be part of the next release of BPGES.