search

boonebgorges / buddypress-group-email-subscription

Fine-grained email subscription for activity in BuddyPress groups
36 stars 32 forks source link

Redirect after all-group-members message is a 404 #248

Closed boonebgorges closed 8 months ago

boonebgorges commented 8 months ago

The redirect following an admin notice is incorrect on very old versions of BuddyPress, or on forks of BuddyPress that don't bother to merge upstream changes in order to remain compatible with freely available BuddyPress plugins. The specific problem in this case is that bp_get_group_permalink() has, for several years, accepted an int $group_id as a parameter, and BPGES (as well as the BP 12.0 polyfill functions recently introduced) leveraged this. See https://buddypress.trac.wordpress.org/ticket/6749. As a fix, I've added fallback support to the polyfill library: https://github.com/hard-g/buddypress-12.0-url-polyfills/commit/b09dc593f40c5b7163c1126377d991be62f0a9cf

boonebgorges commented 8 months ago

See 760e4ec27faaa737d44779cf6d1e730344ff1e9d