boonebgorges / invite-anyone

Invite Anyone - Expands on BuddyPress's invitation features
http://teleogistic.net/code/buddypress/invite-anyone
29 stars 29 forks source link

add option to use BuddyPress notification templates for emails #160

Closed rkzack closed 5 years ago

rkzack commented 5 years ago

This PR adds an option to use BuddyPress notification templates for emails. The default is "no", but this can be changed in the invite-anyone admin panel. If the template doesn't already exist, it's created (and then can be manually customized like any other BP template).

boonebgorges commented 5 years ago

Thanks for sending the PR!

Most of this functionality already exists in the 1.4.x branch on this repo - see the commits linked from #143. One thing I like about your implementation is the "lazy" installation of the post type. But since I have it mostly built already in 1.4.x, I'll probably go mainly with that implementation. In particular, I don't think it's necessary to have a UI toggle letting users disable BP emails - if someone doesn't want BP emails in general, they've already got a solution in place, and if someone wants BP emails in general but not in the case of IA (why?), they can use a filter to disable it.

Your PR does motivate me to go ahead and release the thing though, so thanks :)