Boon Long conversion fails for larger numbers

[SagarN]

Some Numbers whose string length is equal to that of Long.Max
in this case it will fail at digit[1]. The digit[1] is greater than 2 (Long.Max[1])

@Test
    public void testBoonConversion () {
        final String aLongNumberAsString = "1520698688883654656";
        final long aLongNumberAsLong = Long.valueOf(aLongNumberAsString);

        Assert.assertTrue("Number is less than long max ", aLongNumberAsLong < Long.MAX_VALUE);
        Assert.assertEquals(" Numbers should match after conversion", aLongNumberAsString, String.valueOf(aLongNumberAsLong));
        Assert.assertTrue("Should be valid a long ", CharScanner.isLong(aLongNumberAsString.toCharArray(), 0, aLongNumberAsString.length()));

    }

[slandelle]

I've provided a PR against "advantageous/boon" with the fix. It should be easy to port, code seemed identical to me there.

[RichardHightower]

https://github.com/advantageous/boon/pull/19

[RichardHightower]

Sagar... you are using Advantageous Boon BTW since you are using QBit.

[SagarN]

Not sure what it means. Please clarify

• Sagar

On Jun 27, 2016, at 10:08 AM, Richard Hightower notifications@github.com wrote:

Sagar... you are using Advantageous Boon BTW since you are using QBit.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[RichardHightower]

Stephane Landele fixed the qbit boon version. I will do a release with that fix.